train/sft: add type annotations to all Python scripts - #85
Merged
Conversation
Add comprehensive Python type annotations across all 18 scripts in train/sft/, improving IDE support and debuggability of raw data dicts. Changes: - Define TypedDict classes for recurring data shapes: ShareGPTMessage, ShareGPTExample, ImageInfo, DatasetInfoEntry, RetrievalRow, RetrievalHit, SplitStats, EvalResult, EMCharMetrics, JudgeMetrics - Annotate all function/method signatures (params + return types) - Type key local variables (accumulators, containers) where not inferrable from context Bug fixes discovered during analysis: - download_tiles.py: collect_paths() had return annotation set[str] but actually returns dict[str, str | None] — fixed - prepare_sft_data_variable.py L100: removed dead dict comprehension expression whose result was discarded No behavioral changes beyond the dead-code removal. All files pass ruff check, ruff format, and py_compile.
|
@VishvakR is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive Python type annotations across all 18 scripts in train/sft/, improving IDE support and debuggability of raw data dicts.
Changes:
Bug fixes discovered during analysis:
No behavioral changes beyond the dead-code removal. All files pass ruff check, ruff format, and py_compile.
Closes #84